[release 2.11] Update to torch 2.11 by atalman · Pull Request #34644 · vllm-project/vllm

atalman · 2026-02-16T19:54:58Z

Update to Torch 2.11

gemini-code-assist

Code Review

This pull request updates the PyTorch dependency from version 2.10.0 to 2.11.0, along with its companion libraries torchvision (to 0.26.0) and torchaudio (to 2.11.0). The changes are applied consistently across various configuration files, including CMakeLists.txt, Dockerfiles, and requirements files for different platforms (CPU, CUDA, ROCm, XPU). The update appears to be a straightforward and consistent version bump. My review did not identify any critical or high-severity issues in the submitted changes.

mergify · 2026-02-16T19:59:32Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T16:16:27Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T20:37:38Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T20:53:44Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T21:07:43Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T21:29:29Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T21:46:18Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T21:59:37Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T22:22:22Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T22:36:13Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-18T23:20:43Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

mergify · 2026-02-19T02:20:53Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @atalman.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify · 2026-04-01T16:05:07Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

docker/Dockerfile

mgoin · 2026-04-01T16:45:36Z

docker/Dockerfile

 # glibc version is baked into the distro, and binaries built with one glibc
 # version are not backwards compatible with OSes that use an earlier version.
-ARG BUILD_BASE_IMAGE=nvidia/cuda:${CUDA_VERSION}-devel-ubuntu20.04
+ARG BUILD_BASE_IMAGE=nvidia/cuda:${CUDA_VERSION}-devel-ubuntu22.04


Updating the build base image Ubuntu version will likely affect the glibc support, as noted in the comment above. Are there no CUDA 13 images available for 20.04? Cc @tlrmchlsmth

Hi @mgoin no unfortunately they start with 20.04: https://hub.docker.com/r/nvidia/cuda/tags?name=13.0.0-base-ubuntu

mergify · 2026-04-01T18:25:26Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

requirements/cpu-build.txt

mergify · 2026-04-01T19:14:03Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: atalman <atalman@fb.com>

mergify · 2026-04-01T19:58:55Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

atalman · 2026-04-02T15:01:01Z

Kernels Helion Test fixed by: #38062
Kernels Attn test failing on main: https://buildkite.com/vllm/ci/builds/59406#019d4d21-51fb-4223-ae45-67c7ee8a597c
Async Engine failing on main: https://buildkite.com/vllm/ci/builds/59333#019d4b1e-106d-408d-9751-34f2dd2d8421

Pre-Commit looks like existing issue:

Update Dockerfile dependency graph..................................................................Failed
- hook id: update-dockerfile-graph
- exit code: 1
- files were modified by this hook

docker/Dockerfile has changed, attempting to update dependency graph...
Running dockerfilegraph tool...
Unable to find image 'ghcr.io/patrickhoefler/dockerfilegraph:alpine' locally
alpine: Pulling from patrickhoefler/dockerfilegraph

cc @mgoin @khluu

mergify · 2026-04-03T20:18:04Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

mergify · 2026-04-06T17:04:01Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @atalman.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: Andrey Talman <atalman@fb.com>

mergify · 2026-04-06T18:44:22Z

Hi @atalman, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

mergify · 2026-04-06T20:20:49Z

Documentation preview: https://vllm--34644.org.readthedocs.build/en/34644/

AndreasKaratzas · 2026-04-07T22:55:06Z

I enabled some tests for ROCm as well. If possible before next rebase (if there is any) let's wait for those tests to complete. I will check the results here again in about 3 hrs if that is acceptable.

AndreasKaratzas

Only weird part I saw was compared to our nightly: https://buildkite.com/vllm/amd-ci/builds/7368/steps/canvas?sid=019d67ff-82fe-4266-bf39-09f5be890841&tab=output#019d67ff-83f9-433b-8a9e-aa451f43d925/L2538

But this should not be related to AMD CI

AndreasKaratzas · 2026-04-08T00:40:26Z

.buildkite/test_areas/models_language.yaml

    # Note: also needed to run plamo2 model in vLLM
    - uv pip install --system --no-build-isolation 'git+https://github.com/state-spaces/mamba@v2.3.0'
-    - uv pip install --system --no-build-isolation 'git+https://github.com/Dao-AILab/causal-conv1d@v1.5.2'
+    - uv pip install --system --no-build-isolation 'git+https://github.com/Dao-AILab/causal-conv1d@v1.6.0'


Can we also change this version in test-amd.yaml? Btw was there a problem with 1.5.2?

AndreasKaratzas · 2026-04-08T00:42:32Z

.buildkite/test_areas/quantization.yaml

  # we can only upgrade after this is resolved
  # TODO(jerryzh168): resolve the above comment
-  - uv pip install --system torchao==0.14.1 --index-url https://download.pytorch.org/whl/cu129
+  - uv pip install --system torchao==0.17.0 --index-url https://download.pytorch.org/whl/cu130


Torchao seems to be consistent in its failures between this version and our current nightly:

https://buildkite.com/vllm/amd-ci/builds/7364/steps/canvas?sid=019d6686-f3b8-4cf7-b5d8-f295e9246ce9&tab=output#019d6686-f4ac-4f0e-a2fb-2678f5cbf103/L14384

https://buildkite.com/vllm/amd-ci/builds/7364/steps/canvas?sid=019d6686-f37f-4297-b7bf-41c0d80c2cf5&tab=output#019d6686-f47a-4044-aef8-ba982680e9e0/L6902

Therefore, there is no obvious problem here for now.

jikunshang · 2026-04-08T13:06:43Z

thanks for your kindly upgrade for xpu. while xpu have its low level dependency (oneapi, just like nvidia platform have cuda dependency as well). fortunately, 2.10 and 2.11 are share same base dependency version, so everything works fine. Intel will handle further torch-xpu version upgrade to avoid potential break.
Anyway thanks again!

atalman requested review from LucasWilkinson, bigPYJ1151, tjtanaa and tlrmchlsmth as code owners February 16, 2026 19:54

atalman changed the title ~~[release 2.11] Update to torch 2.11~~ [release 2.11] Update to torch 2.11-rc1 Feb 16, 2026

mergify bot added ci/build nvidia rocm Related to AMD ROCm labels Feb 16, 2026

github-project-automation bot added this to NVIDIA and AMD Feb 16, 2026

mergify bot added the cpu Related to CPU backends label Feb 16, 2026

github-project-automation bot moved this to Todo in AMD Feb 16, 2026

gemini-code-assist bot reviewed Feb 16, 2026

View reviewed changes

atalman force-pushed the update_torch_211 branch from 6e3df89 to 7b6c567 Compare February 18, 2026 16:09

atalman requested a review from hmellor as a code owner February 18, 2026 16:09

mergify bot added the needs-rebase label Feb 19, 2026

atalman mentioned this pull request Feb 20, 2026

[cuda 13.0 torch 2.10] [torch 2.11] umbrella issue - vLLM CI failures pytorch/pytorch#175426

Open

14 tasks

atalman force-pushed the update_torch_211 branch from 2b87067 to 0b99aaa Compare February 21, 2026 01:16

zou3519 approved these changes Mar 31, 2026

View reviewed changes

mgoin reviewed Apr 1, 2026

View reviewed changes

fadara01 reviewed Apr 1, 2026

View reviewed changes

requirements/cpu-build.txt Outdated Show resolved Hide resolved

atalman added 5 commits April 1, 2026 12:55

Torch release 2.11 update

eb0f7d3

Signed-off-by: atalman <atalman@fb.com>

Dockerfile

156da9e

Signed-off-by: atalman <atalman@fb.com>

docker

d6c7975

Signed-off-by: atalman <atalman@fb.com>

req

543d8c3

Signed-off-by: atalman <atalman@fb.com>

fix

638af4b

Signed-off-by: atalman <atalman@fb.com>

Merge branch 'main' into update_torch_211

dc7b0c3

khluu added 2 commits April 3, 2026 16:14

Merge branch 'main' into update_torch_211

059f048

Merge branch 'main' into update_torch_211

339f43f

atalman added 2 commits April 6, 2026 10:42

turn_off_helion_tests_211

632a9e4

Merge branch 'main' into update_torch_211

44f2787

Signed-off-by: Andrey Talman <atalman@fb.com>

update

606e7dd

fix

106ae57

AndreasKaratzas approved these changes Apr 8, 2026

View reviewed changes

AndreasKaratzas reviewed Apr 8, 2026

View reviewed changes

vllm-agent mentioned this pull request Apr 8, 2026

Revert "[release 2.11] Update to torch 2.11" (#34644) #39300

Closed

Uh oh!

Conversation

atalman commented Feb 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

mergify bot commented Feb 16, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 18, 2026

Uh oh!

mergify bot commented Feb 19, 2026

Uh oh!

mergify bot commented Apr 1, 2026

Uh oh!

Uh oh!

mgoin Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

atalman Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 1, 2026

Uh oh!

Uh oh!

mergify bot commented Apr 1, 2026

Uh oh!

mergify bot commented Apr 1, 2026

Uh oh!

atalman commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Apr 3, 2026

Uh oh!

mergify bot commented Apr 6, 2026

Uh oh!

mergify bot commented Apr 6, 2026

Uh oh!

mergify bot commented Apr 6, 2026

Uh oh!

AndreasKaratzas commented Apr 7, 2026

Uh oh!

AndreasKaratzas left a comment

Choose a reason for hiding this comment

Uh oh!

AndreasKaratzas Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasKaratzas Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

jikunshang commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

atalman commented Apr 2, 2026 •

edited

Loading